Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: generating a migration using the --sequence flag #39

Merged
merged 4 commits into from
Feb 18, 2022

Conversation

koox00
Copy link
Contributor

@koox00 koox00 commented Feb 11, 2022

It seemed that GetExtension had postgresql as a driver name and not
postgres, which resulted having the sequence number always set to
0000001 for driver postgres.

Also I needed to add the driver to the filepath upon finding the
sequelNumber, else it failed to generate, for both postgres, and mysql drivers.

It seemed that GetExtension had postgresql as a driver name and not
postgres, which resulted having the sequence number always set to
0000001 for driver postgres.

Also I needed to add the driver to the filepath upon finding the
sequelNumber, else it failed to generate.
@isacikgoz isacikgoz self-requested a review February 11, 2022 12:53
@koox00 koox00 changed the title Fixes generate Fixes morph generate Feb 11, 2022
@koox00 koox00 changed the title Fixes morph generate Fixes: generating a migration with the --sequnce flag Feb 11, 2022
@koox00 koox00 changed the title Fixes: generating a migration with the --sequnce flag Fixes: generating a migration using the --sequnce flag Feb 11, 2022
@koox00 koox00 changed the title Fixes: generating a migration using the --sequnce flag Fixes: generating a migration using the --sequence flag Feb 11, 2022
Copy link
Collaborator

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koox00 Are you good for adding some tests for this :p

@koox00
Copy link
Contributor Author

koox00 commented Feb 11, 2022

@koox00 Are you good for adding some tests for this :p

yep, I'm on it

Copy link
Collaborator

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @koox00 🚀

@isacikgoz isacikgoz merged commit 515bbf8 into go-morph:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants